-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[chore] specify default value for tracetest image version #1551
[chore] specify default value for tracetest image version #1551
Conversation
Any reason why you removed the Args? With this, whenever we update the TraceTest we will need to update it in 2 places. |
For build-args to work with our published images the GitHub action workflow would require us to hardcode the version value there. So no matter what we do we need to update the version in 2 places. I opted to use the route where we update the Dockerfile instead of a GitHub action workflow yml. |
* main: (138 commits) docs: update sig meeting schedule (open-telemetry#1567) chore(deps): upgrade otel collector contrib and opensearch (open-telemetry#1566) fix(loadgenerator): use add_hooks openfeature method (open-telemetry#1565) Revert "remove axoflow link (open-telemetry#1457)" (open-telemetry#1563) feat: configure feature flag tracing for Python services (open-telemetry#1553) chore(deps): upgrade go dependencies to latest versions (open-telemetry#1561) remove deprecated version property (open-telemetry#1557) chore(deps): upgrade otel collector contrib, grafana and prometheus (open-telemetry#1559) add imageprovider (open-telemetry#1552) [flagd] - upgrade to latest version and memory limits (open-telemetry#1554) update kubernetes manifest to 1.9.0 (open-telemetry#1555) [chore] specify default value for tracetest image version (open-telemetry#1551) improve baggage propagation (open-telemetry#1545) Bump gradle/wrapper-validation-action from 3.3.1 to 3.3.2 (open-telemetry#1548) [kafka][checkoutservice][frauddetectionservice] add kafkaQueueProblems featureflag (open-telemetry#1528) fix(productcatalogservice): handle err returned from openfeature.SetProvider func (open-telemetry#1535) feat(otelcol): add redisreceiver (open-telemetry#1537) chore(deps): upgrade opentelemetry-java-instrumentation for kafka to 2.3.0 (open-telemetry#1533) Bump gradle/wrapper-validation-action from 3.3.0 to 3.3.1 (open-telemetry#1539) chore(deps): upgrade opentelemetry-java-instrumentation to 2.3.0 (open-telemetry#1532) ... # Conflicts: # docker-compose.minimal.yml # src/frontend/package-lock.json
…etry#1551) * specify default value for tracetest image version * update tracetest to v1.0.0
Fixes #1550
Since the tracetest server and CLI version need to match, we must ensure both images are aligned. The solution is to hardcode the tracetest version in the GitHub workflow or the Dockerfile. I opted to specify this in the Dockerfile, adding a comment on why we need to do it there.