chore(docker compose): add container name as tag attribute to contain… #1495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er logs Signed-off-by: Harry Kimpel <[email protected]>
…er logs Signed-off-by: Harry Kimpel <[email protected]>
|
Please do the same change to docker-compose-minimal.yml. |
…er logs Signed-off-by: Harry Kimpel <[email protected]>
@puckpuck done |
austinlparker
approved these changes
Apr 5, 2024
AlexPSplunk
pushed a commit
to splunk/edu-opentelemetry-demo
that referenced
this pull request
Jul 10, 2024
open-telemetry#1495) * chore(docker compose): add container name as tag attribute to container logs Signed-off-by: Harry Kimpel <[email protected]> * chore(docker compose): add container name as tag attribute to container logs Signed-off-by: Harry Kimpel <[email protected]> * chore(docker compose): add container name as tag attribute to container logs Signed-off-by: Harry Kimpel <[email protected]> --------- Signed-off-by: Harry Kimpel <[email protected]> Co-authored-by: Austin Parker <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…er logs
Changes
Added a minor change to docker-compose.yml
Please provide a brief description of the changes here.
Added some configuration to docker-compose.yml in order to add the respective container name as tag attribute to container logs
Merge Requirements
Due to the minor update to docker-compose.yml, no changes necessary to Demo Helm chart.
For new features contributions please make sure you have completed the following
essential items:
CHANGELOG.mdupdated to document new feature additionsMaintainers will not merge until the above have been completed. If you're unsure
which docs need to be changed ping the
@open-telemetry/demo-approvers.