-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[loadgenerator] added loadgeneratorFloodHomepage flagd #1486
[loadgenerator] added loadgeneratorFloodHomepage flagd #1486
Conversation
6cec944
to
798bb9e
Compare
I tried to run this PR just before the latest commit one hour ago and got it running, but now, for some reason it fails to checkout this branch. For the other PRs this is working:
|
With my first tests, I tried to flood with these settings to go a bit higher:
You could provide more options than just 100. In general, this is a really interesting scenario! With this, one can adjust the load levels outside the LoadGen UI. |
could not replicate the issue from my side
purposely left it on a vague number, for a reason, we can't assume the load but if there is an agreement on the suggestion, I will gladly apply it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, it took a while, but I got rid of the problem in my branch by creating a new branch with
gh pr checkout 1486 -b Load-generator-Web-request-spamming-new
But this PR seems good to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2 minor adjusts, but looks good to me!
6b1a94c
to
404059e
Compare
404059e
to
1c4ed93
Compare
1c4ed93
to
7126e96
Compare
The integration test failure doesn't seem related to this PR, so I'll go ahead and merge. |
…y#1486) * [loadgenerator] added loadgeneratorFloodHomepage flagd * CHANGELOG * Added FLAGD_PORT and depends on the dockercompose
Changes
Added a
loadgeneratorFloodHomepage
flagd that when enabled floods the homepage with a large amount of trafficDepending on the typical load of the sample, the load generation can be overwritten by changing the flagd variant number in the
demo.flagd.json
Merge Requirements
For new features contributions please make sure you have completed the following
essential items:
CHANGELOG.md
updated to document new feature additionsMaintainers will not merge until the above have been completed. If you're unsure
which docs need to be changed ping the
@open-telemetry/demo-approvers.