Adservice returns error status code when feature flag is enabled #1484
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I see. The 1/10th explicit randomness was removed in #1388 but restored via some flagd magic here: https://github.com/open-telemetry/opentelemetry-demo/pull/1388/files#diff-a30814cab829c01672e133c4738a4bff8fd5452a39238f0bbfb32529d9fde441 |
puckpuck
approved these changes
Mar 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the adServiceFailture feature flag is enabled, AdService returns a
RESOURCE_EXHAUSTED = 8grpc status code. This does not result in the span status being set to error according to the grpc semantic conventions: https://github.com/open-telemetry/semantic-conventions/blob/main/docs/rpc/grpc.mdUpdating to return
UNAVAILABLE = 14so that span status is reflected as error as the feature flag implies.Side note: The docs site says that when this feature flag is enabled, an error is generated 1/10th of the time. I don't see any code that would limit this to only 10% of the time. Maybe I'm missing something.