Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[currency] - fix metric name #1470

Merged
merged 3 commits into from
Mar 21, 2024
Merged

[currency] - fix metric name #1470

merged 3 commits into from
Mar 21, 2024

Conversation

puckpuck
Copy link
Contributor

@puckpuck puckpuck commented Mar 20, 2024

Changes

We broke the metric name in #1378. This fixes that name and sets it to app.currency.counter.total as it was before.

Merge Requirements

For new features contributions please make sure you have completed the following
essential items:

  • CHANGELOG.md updated to document new feature additions
  • Appropriate documentation updates in the docs
  • Appropriate Helm chart updates in the helm-charts

Maintainers will not merge until the above have been completed. If you're unsure
which docs need to be changed ping the
@open-telemetry/demo-approvers.

Signed-off-by: Pierre Tessier <[email protected]>
@puckpuck puckpuck requested a review from a team March 20, 2024 03:51
Signed-off-by: Pierre Tessier <[email protected]>
@puckpuck puckpuck merged commit 7560436 into open-telemetry:main Mar 21, 2024
25 checks passed
@puckpuck puckpuck deleted the currency.fix-metric-name branch March 21, 2024 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants