-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[paymentservice] [checkoutservice] introduce new featureflags #1449
[paymentservice] [checkoutservice] introduce new featureflags #1449
Conversation
…ServiceUnreachable featureflags
Hello, as stated above this PR is the updated version of #1383. Sadly it seems like the helm chart is still outdated and I do not see any open PRs addressing that. Can you tell me what the status is there? |
Excelent question! |
There you go: open-telemetry/opentelemetry-helm-charts#1082 |
@julianocosta89, thanks a lot for the info, as soon as this PR is merged I will make the changes to the helm chart. Also, do you perchance know why the |
Testing out your PR, I did see the failing test. I added the fix to your PR, hope you don't mind. |
Changes
This PR is an updated version of #1383 to conform to the updated feature flags. Also a comment regarding the
paymentServiceUnreachable
feature flag was addressed by moving the feature flag to the checkout-service.Merge Requirements
For new features contributions please make sure you have completed the following
essential items:
CHANGELOG.md
updated to document new feature additionsMaintainers will not merge until the above have been completed. If you're unsure
which docs need to be changed ping the
@open-telemetry/demo-approvers.