-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps): update featureflagservice #1224
Conversation
@open-telemetry/erlang-maintainers @open-telemetry/erlang-approvers could someone look into this build failure? |
Pretty sure minor Phoenix releases are basically major ones, hehe, so could be a number of issues in addition to this about not finding the View module. I'll ping the community to see if someone wants to do the upgrade. |
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
Saw this was marked stale. Note that #1238 was opened to resolve the build problem. |
* use Phoenix 1.6 style Phoenix 1.7 has deprecated Phoenix.View in favor of Phoenix.Component and moved the get_flash function out of controllers, making us call it directly * fix deprecated LV stuff Some things have changed in LV, these changes should address that. - some helpers have moved to Phoenix.Component (live_flash) - some syntax changes let={f} vs :let={f} - live_title_tag is now .live_title
Edited/Blocked NotificationRenovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR. You can manually request rebase by checking the rebase/retry box above. ⚠ Warning: custom changes will be lost. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This builds and runs fine now.
* chore(deps): update featureflagservice * use Phoenix 1.6 style (open-telemetry#1238) * use Phoenix 1.6 style Phoenix 1.7 has deprecated Phoenix.View in favor of Phoenix.Component and moved the get_flash function out of controllers, making us call it directly * fix deprecated LV stuff Some things have changed in LV, these changes should address that. - some helpers have moved to Phoenix.Component (live_flash) - some syntax changes let={f} vs :let={f} - live_title_tag is now .live_title --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Austin Parker <[email protected]> Co-authored-by: Tonći Galić <[email protected]>
This PR contains the following updates:
~> 0.7
->~> 0.8
~> 0.34.3
->~> 0.35.0
~> 0.22
->~> 0.23
~> 0.16.0
->~> 0.17.0
~> 1.6.16
->~> 1.7.0
~> 0.17.5
->~> 0.20.0
Release Notes
tsloughter/grpcbox (grpcbox)
v0.17.1
Compare Source
v0.17.0
Compare Source
Configuration
📅 Schedule: Branch creation - "every weekend" (UTC), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.
This PR has been generated by Mend Renovate. View repository job log here.