chore: pinning trace-based test tool version and adding files as volumes #1182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielbdias
changed the title
puckpuck
approved these changes
Oct 20, 2023
Dylan-M
pushed a commit
to observIQ/opentelemetry-demo
that referenced
this pull request
Oct 25, 2023
…mes (open-telemetry#1182) * chore: pinning tracebased test version and adding files as volumes * update changelog * Update CHANGELOG.md --------- Co-authored-by: Juliano Costa <[email protected]> Co-authored-by: Pierre Tessier <[email protected]>
Dylan-M
pushed a commit
to observIQ/opentelemetry-demo
that referenced
this pull request
Oct 25, 2023
…mes (open-telemetry#1182) * chore: pinning tracebased test version and adding files as volumes * update changelog * Update CHANGELOG.md --------- Co-authored-by: Juliano Costa <[email protected]> Co-authored-by: Pierre Tessier <[email protected]>
jmichalak9
pushed a commit
to jmichalak9/opentelemetry-demo
that referenced
this pull request
Mar 22, 2024
…mes (open-telemetry#1182) * chore: pinning tracebased test version and adding files as volumes * update changelog * Update CHANGELOG.md --------- Co-authored-by: Juliano Costa <[email protected]> Co-authored-by: Pierre Tessier <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR pins Tracetest version on
traceBasedTestscontainer to be the same version as intracetest-server. Also, instead of copying the test files to the container, we are using a volume to share the test files on the container. This will make to avoid needing to buildtraceBasedTestsfor every change in the test files.Merge Requirements
For new features contributions please make sure you have completed the following
essential items:
CHANGELOG.mdupdated to document new feature additionsMaintainers will not merge until the above have been completed. If you're unsure
which docs need to be changed ping the
@open-telemetry/demo-approvers.