Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove "hipstershop" from Proto definition #638

Closed
puckpuck opened this issue Dec 14, 2022 · 0 comments · Fixed by #740
Closed

Remove "hipstershop" from Proto definition #638

puckpuck opened this issue Dec 14, 2022 · 0 comments · Fixed by #740
Labels
enhancement New feature or request

Comments

@puckpuck
Copy link
Contributor

The OpenTelemetry demo is now associated with a space exploratory theme that does not fit the original name (and namespace) associated with the original GCP hipstershop project theme that formed the original basis for this demo.

Renaming the hipstershop namespace in the protobuf definition will have an effect on all services, and such a change should be taken with proper care.
@puckpuck puckpuck added the enhancement New feature or request label Dec 14, 2022
codeboten pushed a commit to codeboten/opentelemetry-demo that referenced this issue Feb 10, 2023
rename proto package from hipstershop to oteldemo
5c1132f 
Wanted to see how much work was involved here, open to alternative names. Figured oteldemo was short and to the point :)

Fixes open-telemetry#638

Signed-off-by: Alex Boten <[email protected]>
@codeboten codeboten mentioned this issue Feb 10, 2023
Merged
2 tasks
codeboten pushed a commit to codeboten/opentelemetry-demo that referenced this issue Feb 10, 2023
rename proto package from hipstershop to oteldemo
2d0a369 
Wanted to see how much work was involved here, open to alternative names. Figured oteldemo was short and to the point :)

Fixes open-telemetry#638

Signed-off-by: Alex Boten <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

rename proto package from hipstershop to oteldemo codeboten/opentelemetry-demo
2 participants
@puckpuck @austinlparker