Skip to content

Commit

Permalink
chore: Add yamllint to make all
Browse files Browse the repository at this point in the history
  • Loading branch information
CodePrometheus committed Aug 25, 2024
1 parent a5ed4f3 commit 01e9a0e
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 4 deletions.
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,8 @@ the release.

* [accountingservice] allow running the container with non root user
([#1692](https://github.com/open-telemetry/opentelemetry-demo/pull/1692))
* [chore] Add yamllint to `make all`
([#1707](https://github.com/open-telemetry/opentelemetry-demo/pull/1707))

## 1.11.1

Expand Down
8 changes: 4 additions & 4 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -16,10 +16,10 @@ DOCKER_COMPOSE_ENV=--env-file .env --env-file .env.override
# see https://github.com/open-telemetry/build-tools/releases for semconvgen updates
# Keep links in semantic_conventions/README.md and .vscode/settings.json in sync!
SEMCONVGEN_VERSION=0.11.0
YAMLLINT_VERSION=1.30.0

# TODO: add `yamllint` step to `all` after making sure it works on Mac.
.PHONY: all
all: install-tools markdownlint misspell
all: install-tools markdownlint misspell yamllint

$(MISSPELL):
cd $(TOOLS_DIR) && go build -o $(MISSPELL_BINARY) github.com/client9/misspell/cmd/misspell
Expand All @@ -44,10 +44,10 @@ markdownlint:
.PHONY: install-yamllint
install-yamllint:
# Using a venv is recommended
pip install -U yamllint~=1.30.0
yamllint --version >/dev/null 2>&1 || pip install -U yamllint~=${YAMLLINT_VERSION}

.PHONY: yamllint
yamllint:
yamllint: install-yamllint
yamllint .

.PHONY: checklicense
Expand Down

0 comments on commit 01e9a0e

Please sign in to comment.