Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add note on experimental semantic convention implementation, prefix semantics headers with experimental tag #970

Merged
merged 11 commits into from
Sep 13, 2021
Merged

Add note on experimental semantic convention implementation, prefix semantics headers with experimental tag #970

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
3db914e
add note on experimental semantic conv
lalitb Sep 3, 2021
7c37e80
nit
lalitb Sep 3, 2021
d76aa2a
Merge branch 'main' into experimental-sem-con
lalitb Sep 3, 2021
6445528
Document experimental feature in versioning doc
lalitb Sep 7, 2021
650b83f
Document experimental feature in versioning doc
lalitb Sep 7, 2021
bc85239
Merge branch 'main' into experimental-sem-con
lalitb Sep 9, 2021
f2fe591
rename experimental headers to experimental-*
lalitb Sep 9, 2021
26bff3f
review comments
lalitb Sep 9, 2021
653f90a
Merge branch 'experimental-sem-con' of github.com:lalitb/opentelemetr…
lalitb Sep 9, 2021
3138215
missing changes
lalitb Sep 10, 2021
2aa8755
fix bazel builg
lalitb Sep 10, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions api/include/opentelemetry/trace/semantic_conventions.h
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,12 @@
// Copyright The OpenTelemetry Authors
// SPDX-License-Identifier: Apache-2.0

// NOTE:
lalitb marked this conversation as resolved.
Show resolved Hide resolved
// This implementation is based on the experimental specs for trace semantic convention as defined
// here:
// https://github.com/open-telemetry/opentelemetry-specification/tree/v1.0.0/specification/trace/semantic_conventions
// and MAY will change in future.

#pragma once

#include "opentelemetry/common/string_util.h"
Expand Down
9 changes: 9 additions & 0 deletions sdk/include/opentelemetry/sdk/resource/semantic_conventions.h
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,12 @@
// Copyright The OpenTelemetry Authors
// SPDX-License-Identifier: Apache-2.0

// NOTE:
// This implementation is based on the experimental specs for resource semantic convention as
// defined here:
// https://github.com/open-telemetry/opentelemetry-specification/tree/v1.0.0/specification/resource/semantic_conventions
// and MAY will change in future.

#pragma once

#include <type_traits>
Expand Down