Resolve NOMINMAX issues where possible

[maxgolov]

The issue is that Windows.h redefines both min and max as macros.

There are several fixes possible:

• targeted fix: surround the usage of std::min and std::max with parenthesis; OR
• globally define NOMINMAX for the entire project in CMake; OR
• in those modules where it is known that std::* is going to be used, #define NOMINMAX right before the inclusion of Windows.h

Since there were two recent hits @mishal23 @jsuereth , I'm applying targeted fix to avoid this issue wherever possible.

Not defining NOMINMAX globally, as this may lead to other interesting side-effects inside the bowels of Windows SDK 😁

[ThomsonTan]

EDIT, sorry for the wrong paste. I was asking how could if the user could include windows.h before include our header file.

[maxgolov]

Sorry Tom, what do you mean by C:\GH\otcpp\ext\include\opentelemetry\ext\http\client\curl\http_operation_curl.h(208) ?

[maxgolov]

Reason why I'm adding this is that Josh would need this in his PR that is failing. Related PR: #443

[maxgolov]

if the user could include windows.h before include our header file

Yeah, then it will break for those users. We most likely need to add some blurb in our documentation, that since our SDK uses range limits extensively in public API, that means we should tell users that they must revisit their usage of min and max macros, to make sure we are not breaking them on Windows..

Basically then the user should add the NOMINMAX define on their end ..

[maxgolov]

I tried fixing this where possible. But there are some spots, where our SDK defines class methods called min and max - that will surely break if our Windows customers don't define NOMINMAX themselves for their project.

[codecov]

Codecov Report

Merging #481 (0d705e1) into master (2c97611) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #481      +/-   ##
==========================================
+ Coverage   94.36%   94.38%   +0.02%     
==========================================
  Files         189      189              
  Lines        8410     8410              
==========================================
+ Hits         7936     7938       +2     
+ Misses        474      472       -2     

Impacted Files	Coverage Δ
api/include/opentelemetry/common/spin_lock_mutex.h	33.33% <ø> (ø)
sdk/src/common/fast_random_number_generator.h	100.00% <ø> (ø)
api/include/opentelemetry/nostd/string_view.h	97.56% <100.00%> (ø)
...lemetry/sdk/metrics/aggregator/sketch_aggregator.h	69.76% <100.00%> (ø)
sdk/src/logs/batch_log_processor.cc	95.06% <0.00%> (+1.23%)	⬆️
sdk/test/metrics/counter_aggregator_test.cc	100.00% <0.00%> (+1.78%)	⬆️