-
Notifications
You must be signed in to change notification settings - Fork 440
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use a consistent key for the current span in the context #480
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #480 +/- ##
==========================================
- Coverage 94.43% 94.37% -0.06%
==========================================
Files 187 189 +2
Lines 8244 8410 +166
==========================================
+ Hits 7785 7937 +152
- Misses 459 473 +14
|
pyohannes
added
the
pr:please-merge
This PR is ready to be merged by a Maintainer (rebased, CI passed, has enough valid approvals, etc.)
label
Dec 22, 2020
maxgolov
approved these changes
Dec 22, 2020
jsuereth
approved these changes
Dec 22, 2020
ThomsonTan
reviewed
Dec 22, 2020
Co-authored-by: Tom Tan <[email protected]>
ThomsonTan
approved these changes
Dec 22, 2020
lalitb
approved these changes
Dec 23, 2020
kxyr
pushed a commit
to open-o11y/opentelemetry-cpp
that referenced
this pull request
Dec 31, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
pr:please-merge
This PR is ready to be merged by a Maintainer (rebased, CI passed, has enough valid approvals, etc.)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Extract
call on the W3C propagator used to store the extracted span under the keycurrent-span
in the context, whereas on other places we rely on the current span being stored under the keyspan_key
. This discrepancy will break context propagation.This PR unifies this to use a constant
kSpanKey
in all relevant places and also adds tests.