Add explicit type conversion from std::chrono::milliseconds to long #450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #450 +/- ##
==========================================
- Coverage 94.38% 94.37% -0.02%
==========================================
Files 189 189
Lines 8409 8409
==========================================
- Hits 7937 7936 -1
- Misses 472 473 +1
|
lalitb
approved these changes
Dec 15, 2020
jsuereth
reviewed
Dec 18, 2020
ext/include/opentelemetry/ext/http/client/curl/http_operation_curl.h
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http_conn_timeout_is in typestd::chrono::millisecondswhich has more than 32-bit count asCount(). Add explicit conversion from thisstd::chrono::milliseconds::Count()tolongaslongcould be in 32-bit.