Supporting Logging API .Log() Overloads and GetName() method #422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #422 +/- ##
==========================================
- Coverage 94.38% 94.35% -0.03%
==========================================
Files 185 185
Lines 8014 8047 +33
==========================================
+ Hits 7564 7593 +29
- Misses 450 454 +4
|
lalitb
requested changes
Dec 7, 2020
ThomsonTan
reviewed
Dec 7, 2020
kxyr
pushed a commit
to open-o11y/opentelemetry-cpp
that referenced
this pull request
Dec 7, 2020
ThomsonTan
reviewed
Dec 7, 2020
ThomsonTan
reviewed
Dec 7, 2020
ThomsonTan
reviewed
Dec 7, 2020
ThomsonTan
reviewed
Dec 7, 2020
MarkSeufert
force-pushed
the
logs-api-update
branch
from
724b840 to
e0dd7a7
Compare
kxyr
pushed a commit
to open-o11y/opentelemetry-cpp
that referenced
this pull request
Dec 8, 2020
kxyr
pushed a commit
to open-o11y/opentelemetry-cpp
that referenced
this pull request
Dec 8, 2020
kxyr
pushed a commit
to open-o11y/opentelemetry-cpp
that referenced
this pull request
Dec 8, 2020
pyohannes
reviewed
Dec 9, 2020
This was referenced Dec 9, 2020
|
The Recordable implementation for logs should simplify the overloads here. This PR will be coming in the next few days. Would be good to update/review again this PR after the Recordable is merged. |
kxyr
pushed a commit
to open-o11y/opentelemetry-cpp
that referenced
this pull request
Dec 12, 2020
kxyr
pushed a commit
to open-o11y/opentelemetry-cpp
that referenced
this pull request
Dec 13, 2020
MarkSeufert
force-pushed
the
logs-api-update
branch
2 times, most recently
from
2253df3 to
ca24b29
Compare
jsuereth
approved these changes
Dec 16, 2020
|
@MarkSeufert Can you please rebase this branch with base, so that it is good to merge. |
maxgolov
added
the
pr:please-merge
maxgolov
approved these changes
Dec 18, 2020
MarkSeufert
force-pushed
the
logs-api-update
branch
from
feefa77 to
4310cfc
Compare
kxyr
pushed a commit
to open-o11y/opentelemetry-cpp
that referenced
this pull request
Dec 22, 2020
kxyr
pushed a commit
to open-o11y/opentelemetry-cpp
that referenced
this pull request
Dec 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
.Log()overloads to the Logging API, as well as aGetName()method. More specifically for the overloads, the following was added:Log(Severity, message),Log(Severity, name, message),Log(Severity, KeyValue object),Log(Severity, name, KeyValue object),Log(Severity, initializer list)andLog(Severity, name, initializer list)..Trace(),.Info(),.Debug(),.Warn(),.Error(), and.Fatal().These methods make it easier for users to write simple logs using the API, since they won't have to populate the 9 argument logging statement.
cc - @alolita @xukaren