[SEMANTIC CONVENTIONS] update links to openmetrics to reference the v1.0.0 release #3205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for opentelemetry-cpp-api-docs canceled.
|
ThomsonTan
approved these changes
Dec 13, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3205 +/- ##
=======================================
Coverage 87.83% 87.83%
=======================================
Files 195 195
Lines 6154 6154
=======================================
Hits 5405 5405
Misses 749 749 |
marcalff
approved these changes
Dec 14, 2024
There was a problem hiding this comment.
Files related to semantic conventions are automatically generated,
based on the content of the semantic-convention repository.
You fixed the upstream repository already, with:
which is great.
There is no need to fix this code in opentelemetry-cpp, since the next generation,
once semantic conventions 1.30.0 are released, will update the code with all 1.30.0 changes.
Accepting this PR since it is available, but don't bother manually adjusting generated code in the future.
marcalff
changed the title
Merged
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to prometheus/OpenMetrics#287
The OM 2.0 effort is kicked off, and will start developing on main. This updates the links to OpenMetrics to reference the 1.0 release. The OM project has also been moved into the prometheus github org.