Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

asan: enable more asan and ubsan checks. #224

Merged
merged 8 commits into from
Aug 4, 2020
Merged

Conversation

g-easy
Copy link
Contributor

@g-easy g-easy commented Jul 28, 2020

No description provided.

@g-easy g-easy requested a review from a team July 28, 2020 10:14
@codecov
Copy link

codecov bot commented Jul 28, 2020

Codecov Report

Merging #224 into master will increase coverage by 1.55%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #224      +/-   ##
==========================================
+ Coverage   92.19%   93.75%   +1.55%     
==========================================
  Files         117      104      -13     
  Lines        4038     3251     -787     
==========================================
- Hits         3723     3048     -675     
+ Misses        315      203     -112     
Impacted Files Coverage Δ
api/test/nostd/shared_ptr_test.cc 100.00% <ø> (ø)
api/test/nostd/unique_ptr_test.cc 100.00% <100.00%> (ø)
sdk/src/metrics/meter_provider.cc 100.00% <0.00%> (ø)
...include/opentelemetry/sdk/metrics/meter_provider.h 100.00% <0.00%> (ø)
api/include/opentelemetry/metrics/meter.h
.../opentelemetry/sdk/metrics/aggregator/aggregator.h
.../metrics/aggregator/min_max_sum_count_aggregator.h
.../test/metrics/min_max_sum_count_aggregator_test.cc
sdk/test/metrics/counter_aggregator_test.cc
...emetry/sdk/metrics/aggregator/counter_aggregator.h
... and 9 more

@g-easy
Copy link
Contributor Author

g-easy commented Jul 30, 2020

PTAL.

Also please clean up the description before merging, or let me merge it. :)

@pyohannes pyohannes added the pr:please-merge This PR is ready to be merged by a Maintainer (rebased, CI passed, has enough valid approvals, etc.) label Jul 30, 2020
@g-easy
Copy link
Contributor Author

g-easy commented Aug 4, 2020

Hmm I was too slow to merge this and now //sdk/test/metrics:counter_aggregator_test is failing.

@g-easy g-easy merged commit d9035ef into open-telemetry:master Aug 4, 2020
@g-easy g-easy deleted the asan branch August 4, 2020 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr:please-merge This PR is ready to be merged by a Maintainer (rebased, CI passed, has enough valid approvals, etc.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants