Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove include_trace_context #2194

Merged
merged 2 commits into from
Jun 12, 2023

Conversation

owent
Copy link
Member

@owent owent commented Jun 12, 2023

Fixes #2104

Changes

Please provide a brief description of the changes here.

  • Remove include_trace_context

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

@owent owent requested a review from a team June 12, 2023 09:27
@codecov
Copy link

codecov bot commented Jun 12, 2023

Codecov Report

Merging #2194 (c6a2354) into main (bd83aa3) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2194   +/-   ##
=======================================
  Coverage   87.52%   87.52%           
=======================================
  Files         169      169           
  Lines        4887     4887           
=======================================
  Hits         4277     4277           
  Misses        610      610           

Signed-off-by: owent <[email protected]>
@owent owent changed the title [WIP] Remove include_trace_context Remove include_trace_context Jun 12, 2023
Copy link
Member

@marcalff marcalff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the cleanup.

Copy link
Member

@lalitb lalitb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the PR

@marcalff marcalff merged commit 773a172 into open-telemetry:main Jun 12, 2023
@owent owent deleted the remove_include_trace_context branch July 4, 2023 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Logs API/SDK] Drop include_trace_context parameter from LoggerProvider::GetLogger()
3 participants