Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ctime header to metrics_exporter.cc #2187

Merged
merged 2 commits into from
Jun 9, 2023

Conversation

ThomsonTan
Copy link
Contributor

Fixes #2186

Header file ctime is needed for using std::time_t in std::strftime.

Changes

Please provide a brief description of the changes here.

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

@ThomsonTan ThomsonTan requested a review from a team June 9, 2023 00:37
Copy link
Member

@marcalff marcalff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, assuming minor cleanup for clang-format.

Thanks for the fix.

@codecov
Copy link

codecov bot commented Jun 9, 2023

Codecov Report

Merging #2187 (e040082) into main (d233b9b) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2187   +/-   ##
=======================================
  Coverage   87.52%   87.52%           
=======================================
  Files         169      169           
  Lines        4887     4887           
=======================================
  Hits         4277     4277           
  Misses        610      610           
Impacted Files Coverage Δ
exporters/ostream/src/metric_exporter.cc 91.81% <ø> (ø)

@marcalff marcalff merged commit c89a6fd into open-telemetry:main Jun 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build console metrics exporter failed on Windows with VS2017
4 participants