Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SDK] Add benchmark for base2 exponential histogram indexer #2181

Merged
merged 4 commits into from
Jun 7, 2023

Conversation

euroelessar
Copy link
Contributor

Updates #1391

Changes

Add benchmark to measure performance of the indexer.

Results from a dev instance:

Run on (16 X 2899.97 MHz CPU s)
CPU Caches:
  L1 Data 48 KiB (x8)
  L1 Instruction 32 KiB (x8)
  L2 Unified 1280 KiB (x8)
  L3 Unified 55296 KiB (x1)
Load Average: 1.00, 0.33, 0.15
-------------------------------------------------------------
Benchmark                   Time             CPU   Iterations
-------------------------------------------------------------
BM_NewIndexer            5.73 ns         5.74 ns    121518000
BM_ComputeIndex/-1       4.09 ns         4.09 ns    171316000
BM_ComputeIndex/0        4.08 ns         4.08 ns    171349000
BM_ComputeIndex/1        8.62 ns         8.63 ns     81330000
BM_ComputeIndex/20       8.60 ns         8.61 ns     81323000

Negative scale has better performance due to using a custom more optimized path.

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

```
Run on (16 X 2899.97 MHz CPU s)
CPU Caches:
  L1 Data 48 KiB (x8)
  L1 Instruction 32 KiB (x8)
  L2 Unified 1280 KiB (x8)
  L3 Unified 55296 KiB (x1)
Load Average: 1.00, 0.33, 0.15
-------------------------------------------------------------
Benchmark                   Time             CPU   Iterations
-------------------------------------------------------------
BM_NewIndexer            5.73 ns         5.74 ns    121518000
BM_ComputeIndex/-1       4.09 ns         4.09 ns    171316000
BM_ComputeIndex/0        4.08 ns         4.08 ns    171349000
BM_ComputeIndex/1        8.62 ns         8.63 ns     81330000
BM_ComputeIndex/20       8.60 ns         8.61 ns     81323000
```
@euroelessar euroelessar requested a review from a team June 6, 2023 02:24
@codecov
Copy link

codecov bot commented Jun 6, 2023

Codecov Report

Merging #2181 (f966b99) into main (d980e8b) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2181   +/-   ##
=======================================
  Coverage   87.52%   87.52%           
=======================================
  Files         169      169           
  Lines        4887     4887           
=======================================
  Hits         4277     4277           
  Misses        610      610           

Copy link
Member

@marcalff marcalff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the contribution.

Copy link
Member

@lalitb lalitb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks

@lalitb lalitb added the ok-to-merge The PR is ok to merge (has two approves or raised by a maintainer/approver and has one approve) label Jun 7, 2023
Copy link
Member

@esigo esigo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thank :)

@marcalff marcalff merged commit d233b9b into open-telemetry:main Jun 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ok-to-merge The PR is ok to merge (has two approves or raised by a maintainer/approver and has one approve)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants