Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SDK] Simplify SDK version #2180

Merged
merged 2 commits into from
Jun 6, 2023

Conversation

marcalff
Copy link
Member

@marcalff marcalff commented Jun 5, 2023

Fixes #2150

Changes

Removed the following members:

  • sdk::version::count_new_commits
  • sdk::version::branch
  • sdk::version::commit_hash

Simplified sdk::version::full_version accordingly.

Simplified buildscripts/pre-commit accordingly.

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

@marcalff marcalff requested a review from a team June 5, 2023 22:07
@codecov
Copy link

codecov bot commented Jun 5, 2023

Codecov Report

❗ No coverage uploaded for pull request base (main@600bd30). Click here to learn what that means.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2180   +/-   ##
=======================================
  Coverage        ?   87.52%           
=======================================
  Files           ?      169           
  Lines           ?     4887           
  Branches        ?        0           
=======================================
  Hits            ?     4277           
  Misses          ?      610           
  Partials        ?        0           

@marcalff marcalff merged commit d980e8b into open-telemetry:main Jun 6, 2023
@marcalff marcalff deleted the fix_sdk_version_2150 branch September 5, 2023 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[SDK] Simplify SDK version
3 participants