-
Notifications
You must be signed in to change notification settings - Fork 415
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SDK] Add base2 exponential histogram indexer #2173
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, and well done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2173 +/- ##
==========================================
+ Coverage 87.48% 87.50% +0.03%
==========================================
Files 168 169 +1
Lines 4869 4887 +18
==========================================
+ Hits 4259 4276 +17
- Misses 610 611 +1
|
Is there a timeline/plan as to when the exponential histogram would be in usable shape? @euroelessar Could you please specify the next steps one would need to take to implement this? I've been going over the code and would like to take a stab at it. |
Updates #1391
Changes
Add Base2ExponentialHistogramIndexer for calculating index for a given value and scale.
It will be used in base2 exponential histogram in followup changes.
For significant contributions please make sure you have completed the following items:
CHANGELOG.md
updated for non-trivial changes