Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SDK] Add base2 exponential histogram indexer #2173

Merged
merged 5 commits into from
Jun 3, 2023

Conversation

euroelessar
Copy link
Contributor

Updates #1391

Changes

Add Base2ExponentialHistogramIndexer for calculating index for a given value and scale.
It will be used in base2 exponential histogram in followup changes.

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

@euroelessar euroelessar requested a review from a team June 1, 2023 22:16
Copy link
Member

@marcalff marcalff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, and well done.

Copy link
Member

@esigo esigo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thanks :)

@esigo esigo added the ok-to-merge The PR is ok to merge (has two approves or raised by a maintainer/approver and has one approve) label Jun 2, 2023
Copy link
Member

@lalitb lalitb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks

@codecov
Copy link

codecov bot commented Jun 3, 2023

Codecov Report

Merging #2173 (cd45a94) into main (f5fd906) will increase coverage by 0.03%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2173      +/-   ##
==========================================
+ Coverage   87.48%   87.50%   +0.03%     
==========================================
  Files         168      169       +1     
  Lines        4869     4887      +18     
==========================================
+ Hits         4259     4276      +17     
- Misses        610      611       +1     
Impacted Files Coverage Δ
...aggregation/base2_exponential_histogram_indexer.cc 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

@marcalff marcalff merged commit 082bb93 into open-telemetry:main Jun 3, 2023
@dufferzafar
Copy link

Is there a timeline/plan as to when the exponential histogram would be in usable shape?

@euroelessar Could you please specify the next steps one would need to take to implement this?

I've been going over the code and would like to take a stab at it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ok-to-merge The PR is ok to merge (has two approves or raised by a maintainer/approver and has one approve)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants