Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change OTLP Json field name to camelCase #2162

Merged

Conversation

owent
Copy link
Member

@owent owent commented May 27, 2023

Fixes #2157

Changes

  • Change OTLP Json field name to camelCase

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

@owent owent requested a review from a team May 27, 2023 04:04
@codecov
Copy link

codecov bot commented May 27, 2023

Codecov Report

Merging #2162 (bec2df8) into main (f553462) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2162   +/-   ##
=======================================
  Coverage   87.17%   87.17%           
=======================================
  Files         166      166           
  Lines        4777     4777           
=======================================
  Hits         4164     4164           
  Misses        613      613           

Signed-off-by: owent <[email protected]>
Copy link
Member

@esigo esigo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
thanks :)

Copy link
Member

@marcalff marcalff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the fix.

@marcalff marcalff merged commit 8b7f9b4 into open-telemetry:main May 27, 2023
@owent owent deleted the change_otlp_json_field_name_to_camel branch July 4, 2023 03:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ensure that OTLP/JSON exporter uses correct capitalization of field names
3 participants