Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RELEASE] Prepare release 1.9.1 #2149

Merged
merged 6 commits into from
May 26, 2023

Conversation

marcalff
Copy link
Member

@marcalff marcalff commented May 23, 2023

Fixes #2148

Changes

Please provide a brief description of the changes here.

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

@marcalff marcalff requested a review from a team May 23, 2023 09:22
@codecov
Copy link

codecov bot commented May 23, 2023

Codecov Report

Merging #2149 (bbb4f48) into main (32a8235) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2149   +/-   ##
=======================================
  Coverage   87.17%   87.17%           
=======================================
  Files         166      166           
  Lines        4777     4777           
=======================================
  Hits         4164     4164           
  Misses        613      613           

owent

This comment was marked as outdated.

owent

This comment was marked as duplicate.

@marcalff
Copy link
Member Author

@owent

Do we also need update version.h?

Both files:

./api/include/opentelemetry/version.h
./sdk/include/opentelemetry/sdk/version/version.h

are updated.

Copy link
Member

@esigo esigo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thanks :)

@owent
Copy link
Member

owent commented May 24, 2023

@owent

Do we also need update version.h?

Both files:

./api/include/opentelemetry/version.h ./sdk/include/opentelemetry/sdk/version/version.h

are updated.

Thanks, maybe there is some wrong with my network, I find only one changed file when first open this PR, and there is no problem now.

@marcalff
Copy link
Member Author

marcalff commented May 24, 2023

Release on hold, waiting for:

to avoid breaking the build for applications with 1.9.1

@marcalff marcalff added the pr:do-not-merge This PR is not ready to be merged. label May 24, 2023
@marcalff marcalff removed the pr:do-not-merge This PR is not ready to be merged. label May 26, 2023
@marcalff marcalff merged commit 770fce3 into open-telemetry:main May 26, 2023
@marcalff marcalff deleted the make_release_1.9.1 branch September 5, 2023 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[RELEASE] Prepare release 1.9.1
5 participants