Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Make build environment parallel (Linux) #2076

Merged
merged 1 commit into from
Mar 28, 2023

Conversation

cngzhnp
Copy link
Contributor

@cngzhnp cngzhnp commented Mar 27, 2023

Fixes #2074

Changes

Some of targets does not contain parallel build mechanism which was supported by default.

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

@cngzhnp cngzhnp force-pushed the make_targets_build_parallel branch from 61d2ec0 to 6028140 Compare March 27, 2023 23:54
@cngzhnp cngzhnp marked this pull request as ready for review March 27, 2023 23:55
@cngzhnp cngzhnp requested a review from a team March 27, 2023 23:55
@codecov
Copy link

codecov bot commented Mar 28, 2023

Codecov Report

Merging #2076 (6028140) into main (bd7a3c7) will decrease coverage by 0.02%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2076      +/-   ##
==========================================
- Coverage   87.19%   87.17%   -0.02%     
==========================================
  Files         166      166              
  Lines        4784     4784              
==========================================
- Hits         4171     4170       -1     
- Misses        613      614       +1     

see 1 file with indirect coverage changes

Copy link
Member

@owent owent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and thanks.

Copy link
Member

@marcalff marcalff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the fix.

@cngzhnp
Copy link
Contributor Author

cngzhnp commented Mar 28, 2023

It does fix only for UNIX based system and must be improved for Windows-based systems as well. I will create another issue for Windows-based build systems if it is OK for everyone? And maybe I should change this issue title like "Make some targets parallel in CI pipeline for UNIX based systems".

@marcalff
Copy link
Member

It does fix only for UNIX based system and must be improved for Windows-based systems as well. I will create another issue for Windows-based build systems if it is OK for everyone? And maybe I should change this issue title like "Make some targets parallel in CI pipeline for UNIX based systems".

Once @lalitb or @ThomsonTan or @esigo have a chance to review it and add the magic ok-to-merge flag, I can take care of the merge itself.

@cngzhnp For windows, a separate PR will be better, so this one can be merged now.

@marcalff marcalff changed the title Make some targets parallel in CI pipeline Make some targets parallel in CI pipeline (UNIX) Mar 28, 2023
@lalitb lalitb added the ok-to-merge The PR is ok to merge (has two approves or raised by a maintainer/approver and has one approve) label Mar 28, 2023
@marcalff marcalff merged commit b793426 into open-telemetry:main Mar 28, 2023
@marcalff marcalff changed the title Make some targets parallel in CI pipeline (UNIX) [CI] Make build environment parallel (Linux) Apr 12, 2023
ays7 added a commit to ays7/opentelemetry-cpp that referenced this pull request May 18, 2023
* commit '7887d32da60f54984a597abccbb0c883f3a51649': (82 commits)
  [RELEASE] Release version 1.9.0 (open-telemetry#2091)
  Use sdk_start_ts for MetricData start_ts for instruments having cumulative aggregation temporality. (open-telemetry#2086)
  [SEMANTIC CONVENTIONS] Upgrade to version 1.20.0 (open-telemetry#2088)
  [EXPORTER] Add OTLP HTTP SSL support (open-telemetry#1793)
  Make Windows build environment parallel (open-telemetry#2080)
  make some hints (open-telemetry#2078)
  Make some targets parallel in CI pipeline (open-telemetry#2076)
  [Metrics SDK] Implement Forceflush for Periodic Metric Reader (open-telemetry#2064)
  Upgraded semantic conventions to 1.19.0 (open-telemetry#2017)
  Bump actions/stale from 7 to 8 (open-telemetry#2070)
  Include directory path added for Zipkin exporter example (open-telemetry#2069)
  Ignore more warning of generated protobuf files than not included in `-Wall` and `-Wextra` (open-telemetry#2067)
  Add `ForceFlush` for all `LogRecordExporter`s and `SpanExporter`s. (open-telemetry#2000)
  Remove unused 'alerting' section from prometheus.yml in examples (open-telemetry#2055)
  Clean warnings in ETW exporters (open-telemetry#2063)
  Fix default value of `OPENTELEMETRY_INSTALL_default`. (open-telemetry#2062)
  [EXPORTER] GRPC endpoint scheme should take precedence over OTEL_EXPORTER_OTLP_TRACES_INSECURE (open-telemetry#2060)
  Fix view names in Prometheus example (open-telemetry#2034)
  Fix some docs typo (open-telemetry#2057)
  Checking indices before dereference (open-telemetry#2040)
  ...

# Conflicts:
#	exporters/ostream/CMakeLists.txt
#	sdk/src/metrics/state/metric_collector.cc
#	sdk/src/metrics/state/temporal_metric_storage.cc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ok-to-merge The PR is ok to merge (has two approves or raised by a maintainer/approver and has one approve)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Some of CI build targets are not compiled in parallel
4 participants