Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Logs SDK] LogProcessor, LogExporter class name #1736

Merged
merged 5 commits into from
Nov 6, 2022

Conversation

esigo
Copy link
Member

@esigo esigo commented Nov 5, 2022

Fixes #1694 (issue)

Changes

exporters class names to use "*LogRecordExporter", to be in consistent with the file-names, and naming of their cmake/bazel targets:

ElasticsearchLogExporter to ElasticsearchLogRecordExporter
OStreamLogExporter to OStreamLogRecordExporter
OtlpGrpcLogExporter to OtlpGrpcLogRecordExporter
OtlpHttpLogExporter to OtlpHttpLogRecordExporter

And similarly for Processors:
BatchLogProcessor to BatchLogRecordProcessor
SimpleLogProcessor to SimpleLogRecordProcessor
MultiLogProcessor to MultiLogRecordProcessor

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

@codecov
Copy link

codecov bot commented Nov 5, 2022

Codecov Report

Merging #1736 (068587d) into main (ec8895b) will decrease coverage by 0.02%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1736      +/-   ##
==========================================
- Coverage   85.79%   85.77%   -0.01%     
==========================================
  Files         171      171              
  Lines        5212     5212              
==========================================
- Hits         4471     4470       -1     
- Misses        741      742       +1     
Impacted Files Coverage Δ
sdk/src/trace/batch_span_processor.cc 90.63% <0.00%> (-0.78%) ⬇️

@esigo esigo marked this pull request as ready for review November 5, 2022 11:42
@esigo esigo requested a review from a team November 5, 2022 11:42
@esigo esigo added the logs label Nov 5, 2022
Copy link
Member

@owent owent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@lalitb lalitb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the change.

@esigo esigo enabled auto-merge (squash) November 6, 2022 19:08
@esigo esigo merged commit 7efeeab into open-telemetry:main Nov 6, 2022
@esigo esigo deleted the log_exporter_names branch November 6, 2022 20:08
yxue pushed a commit to yxue/opentelemetry-cpp that referenced this pull request Dec 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Logs SDK] LogProcessor, LogExporter changes
3 participants