Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MetricStorage dtors #1270

Merged
merged 1 commit into from
Mar 18, 2022
Merged

MetricStorage dtors #1270

merged 1 commit into from
Mar 18, 2022

Conversation

esigo
Copy link
Member

@esigo esigo commented Mar 17, 2022

Adds missing MetricStorage virtual dtors

Please provide a brief description of the changes here.

Also adds clangd cache to gitignore.

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

@esigo esigo requested a review from a team March 17, 2022 22:04
Copy link
Member

@lalitb lalitb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix.

@codecov
Copy link

codecov bot commented Mar 17, 2022

Codecov Report

Merging #1270 (a3bf48d) into main (0b1a74c) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1270      +/-   ##
==========================================
+ Coverage   92.37%   92.37%   +0.01%     
==========================================
  Files         202      203       +1     
  Lines        7336     7338       +2     
==========================================
+ Hits         6776     6778       +2     
  Misses        560      560              
Impacted Files Coverage Δ
...e/opentelemetry/sdk/metrics/state/metric_storage.h 100.00% <100.00%> (ø)

@lalitb lalitb merged commit 6bd2f96 into open-telemetry:main Mar 18, 2022
DebajitDas pushed a commit to DebajitDas/opentelemetry-cpp that referenced this pull request Mar 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants