Skip to content

Commit

Permalink
[bazel] Enable --incompatible_disallow_empty_glob (#2642)
Browse files Browse the repository at this point in the history
  • Loading branch information
@keith
keith authored Nov 23, 2024
1 parent 6a77bcd commit 9d998e3
Show file tree
Hide file tree
Showing 4 changed files with 3 additions and 3 deletions.
3 changes: 3 additions & 0 deletions .bazelrc
View file
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,9 @@
# Enable automatic configs based on platform
common --enable_platform_specific_config

# Make globs that don't match anything fail
common --incompatible_disallow_empty_glob

# Needed by gRPC to build on some platforms.
build --copt -DGRPC_BAZEL_BUILD

Expand Down
1 change: 0 additions & 1 deletion sdk/src/logs/BUILD
View file
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ package(default_visibility = ["//visibility:public"])
cc_library(
name = "logs",
srcs = glob(["**/*.cc"]),
hdrs = glob(["**/*.h"]),
include_prefix = "src/logs",
deps = [
"//api",
Expand Down
1 change: 0 additions & 1 deletion sdk/src/metrics/BUILD
View file
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ package(default_visibility = ["//visibility:public"])
cc_library(
name = "metrics",
srcs = glob(["**/*.cc"]),
hdrs = glob(["**/*.h"]),
include_prefix = "src/metrics",
deps = [
"//api",
Expand Down
1 change: 0 additions & 1 deletion sdk/src/resource/BUILD
View file
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ package(default_visibility = ["//visibility:public"])
cc_library(
name = "resource",
srcs = glob(["**/*.cc"]),
hdrs = glob(["**/*.h"]),
include_prefix = "src/resource",
deps = [
"//api",
Expand Down

1 comment on commit 9d998e3

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'OpenTelemetry-cpp api Benchmark'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 2.

Benchmark suite Current: 9d998e3 Previous: 6a77bcd Ratio
BM_NaiveSpinLockThrashing/1/process_time/real_time 0.2881602748580601 ms/iter 0.11157846450805664 ms/iter 2.58
BM_NaiveSpinLockThrashing/2/process_time/real_time 0.565485449026752 ms/iter 0.26169861897383584 ms/iter 2.16

This comment was automatically generated by workflow using github-action-benchmark.

Please sign in to comment.