Added directories excluding tools, .git, third_party, opentelemetry_l…

…ogo.png, TraceLoggingDynamic.h, Included formatting changes from tools/format.sh
open-telemetry · Jul 3, 2024 · 7aaca5a · 7aaca5a
1 parent 9e36d31
commit 7aaca5a
Show file tree

Hide file tree

Showing 39 changed files with 101 additions and 84 deletions.
diff --git a/api/include/opentelemetry/context/context.h b/api/include/opentelemetry/context/context.h
@@ -4,6 +4,7 @@
 #pragma once
 
 #include <cstring>
+#include <utility>
 #include "opentelemetry/context/context_value.h"
 #include "opentelemetry/nostd/shared_ptr.h"
 #include "opentelemetry/nostd/string_view.h"
@@ -32,7 +33,7 @@ class Context
 
   // Creates a context object from a key and value, this will
   // hold a shared_ptr to the head of the DataList linked list
-  Context(nostd::string_view key, ContextValue value) noexcept
+  Context(nostd::string_view key, const ContextValue &value) noexcept
   {
     head_ = nostd::shared_ptr<DataList>{new DataList(key, value)};
   }
@@ -58,7 +59,7 @@ class Context
   // exisiting list to the end of the new list.
   Context SetValue(nostd::string_view key, ContextValue value) noexcept
   {
-    Context context      = Context(key, value);
+    Context context      = Context(key, std::move(value));
     context.head_->next_ = head_;
     return context;
   }

diff --git a/api/include/opentelemetry/context/propagation/global_propagator.h b/api/include/opentelemetry/context/propagation/global_propagator.h
@@ -4,6 +4,7 @@
 #pragma once
 
 #include <mutex>
+#include <utility>
 
 #include "opentelemetry/context/propagation/noop_propagator.h"
 
@@ -35,7 +36,7 @@ class OPENTELEMETRY_EXPORT GlobalTextMapPropagator
   static void SetGlobalPropagator(nostd::shared_ptr<TextMapPropagator> prop) noexcept
   {
     std::lock_guard<common::SpinLockMutex> guard(GetLock());
-    GetPropagator() = prop;
+    GetPropagator() = std::move(prop);
   }
 
 private:

diff --git a/api/include/opentelemetry/context/runtime_context.h b/api/include/opentelemetry/context/runtime_context.h
@@ -3,6 +3,8 @@
 
 #pragma once
 
+#include <utility>
+
 #include "opentelemetry/common/macros.h"
 #include "opentelemetry/context/context.h"
 #include "opentelemetry/nostd/shared_ptr.h"
@@ -150,7 +152,7 @@ class OPENTELEMETRY_EXPORT RuntimeContext
    */
   static void SetRuntimeContextStorage(nostd::shared_ptr<RuntimeContextStorage> storage) noexcept
   {
-    GetStorage() = storage;
+    GetStorage() = std::move(storage);
   }
 
   /**

diff --git a/api/include/opentelemetry/logs/provider.h b/api/include/opentelemetry/logs/provider.h
@@ -4,6 +4,7 @@
 #pragma once
 
 #include <mutex>
+#include <utility>
 
 #include "opentelemetry/common/macros.h"
 #include "opentelemetry/common/spin_lock_mutex.h"
@@ -42,7 +43,7 @@ class OPENTELEMETRY_EXPORT Provider
   static void SetLoggerProvider(nostd::shared_ptr<LoggerProvider> tp) noexcept
   {
     std::lock_guard<common::SpinLockMutex> guard(GetLock());
-    GetProvider() = tp;
+    GetProvider() = std::move(tp);
   }
 
   /**
@@ -63,7 +64,7 @@ class OPENTELEMETRY_EXPORT Provider
   static void SetEventLoggerProvider(nostd::shared_ptr<EventLoggerProvider> tp) noexcept
   {
     std::lock_guard<common::SpinLockMutex> guard(GetLock());
-    GetEventProvider() = tp;
+    GetEventProvider() = std::move(tp);
   }
 
 private:

diff --git a/api/include/opentelemetry/metrics/provider.h b/api/include/opentelemetry/metrics/provider.h
@@ -4,6 +4,7 @@
 #pragma once
 
 #include <mutex>
+#include <utility>
 
 #include "opentelemetry/common/macros.h"
 #include "opentelemetry/common/spin_lock_mutex.h"
@@ -41,7 +42,7 @@ class Provider
   static void SetMeterProvider(nostd::shared_ptr<MeterProvider> tp) noexcept
   {
     std::lock_guard<common::SpinLockMutex> guard(GetLock());
-    GetProvider() = tp;
+    GetProvider() = std::move(tp);
   }
 
 private:

diff --git a/api/include/opentelemetry/nostd/internal/absl/base/internal/inline_variable.h b/api/include/opentelemetry/nostd/internal/absl/base/internal/inline_variable.h
@@ -68,15 +68,15 @@
 //   types, etc..
 #if defined(__clang__)
 #define OTABSL_INTERNAL_EXTERN_DECL(type, name) \
-  extern const ::absl::OTABSL_OPTION_INLINE_NAMESPACE_NAME::internal::identity_t<type> name;
+  extern const ::absl::OTABSL_OPTION_INLINE_NAMESPACE_NAME::internal::identity_t<type> (name);
 #else  // Otherwise, just define the macro to do nothing.
 #define OTABSL_INTERNAL_EXTERN_DECL(type, name)
 #endif  // defined(__clang__)
 
 // See above comment at top of file for details.
 #define OTABSL_INTERNAL_INLINE_CONSTEXPR(type, name, init) \
   OTABSL_INTERNAL_EXTERN_DECL(type, name)                  \
-  inline constexpr ::absl::OTABSL_OPTION_INLINE_NAMESPACE_NAME::internal::identity_t<type> name = init
+  inline constexpr ::absl::OTABSL_OPTION_INLINE_NAMESPACE_NAME::internal::identity_t<type> (name) = init
 
 #else
 

diff --git a/api/include/opentelemetry/plugin/tracer.h b/api/include/opentelemetry/plugin/tracer.h
@@ -4,6 +4,7 @@
 #pragma once
 
 #include <memory>
+#include <utility>
 
 #include "opentelemetry/common/key_value_iterable.h"
 #include "opentelemetry/plugin/detail/tracer_handle.h"  // IWYU pragma: export
@@ -21,7 +22,7 @@ class Span final : public trace::Span
 {
 public:
   Span(std::shared_ptr<trace::Tracer> &&tracer, nostd::shared_ptr<trace::Span> span) noexcept
-      : tracer_{std::move(tracer)}, span_{span}
+      : tracer_{std::move(tracer)}, span_{std::move(span)}
   {}
 
   // trace::Span

diff --git a/api/include/opentelemetry/trace/default_span.h b/api/include/opentelemetry/trace/default_span.h
@@ -63,7 +63,7 @@ class DefaultSpan : public Span
 
   nostd::string_view ToString() const noexcept { return "DefaultSpan"; }
 
-  DefaultSpan(SpanContext span_context) noexcept : span_context_(span_context) {}
+  DefaultSpan(const SpanContext &span_context) noexcept : span_context_(span_context) {}
 
   // movable and copiable
   DefaultSpan(DefaultSpan &&spn) noexcept : span_context_(spn.GetContext()) {}

diff --git a/api/include/opentelemetry/trace/provider.h b/api/include/opentelemetry/trace/provider.h
@@ -4,6 +4,7 @@
 #pragma once
 
 #include <mutex>
+#include <utility>
 
 #include "opentelemetry/common/macros.h"
 #include "opentelemetry/common/spin_lock_mutex.h"
@@ -41,7 +42,7 @@ class OPENTELEMETRY_EXPORT Provider
   static void SetTracerProvider(nostd::shared_ptr<TracerProvider> tp) noexcept
   {
     std::lock_guard<common::SpinLockMutex> guard(GetLock());
-    GetProvider() = tp;
+    GetProvider() = std::move(tp);
   }
 
 private:

diff --git a/api/include/opentelemetry/trace/span_context.h b/api/include/opentelemetry/trace/span_context.h
@@ -3,6 +3,8 @@
 
 #pragma once
 
+#include <utility>
+
 #include "opentelemetry/nostd/shared_ptr.h"
 #include "opentelemetry/trace/span_id.h"
 #include "opentelemetry/trace/trace_flags.h"
@@ -44,7 +46,7 @@ class SpanContext final
         span_id_(span_id),
         trace_flags_(trace_flags),
         is_remote_(is_remote),
-        trace_state_(trace_state)
+        trace_state_(std::move(trace_state))
   {}
 
   SpanContext(const SpanContext &ctx) = default;

diff --git a/api/include/opentelemetry/trace/span_context_kv_iterable_view.h b/api/include/opentelemetry/trace/span_context_kv_iterable_view.h
@@ -32,7 +32,7 @@ inline void take_span_context_kv(SpanContext, T &)
 {}
 
 inline void take_span_context_kv(
-    SpanContext,
+    const SpanContext &,
     std::initializer_list<std::pair<nostd::string_view, common::AttributeValue>>)
 {}
 
@@ -81,7 +81,7 @@ class SpanContextKeyValueIterableView final : public SpanContextKeyValueIterable
 private:
   const T *container_;
 
-  bool do_callback(SpanContext span_context,
+  bool do_callback(const SpanContext &span_context,
                    const common::KeyValueIterable &attributes,
                    nostd::function_ref<bool(SpanContext, const common::KeyValueIterable &)>
                        callback) const noexcept

diff --git a/api/test/baggage/propagation/baggage_propagator_test.cc b/api/test/baggage/propagation/baggage_propagator_test.cc
@@ -62,7 +62,7 @@ TEST(BaggagePropagatorTest, ExtractAndInjectBaggage)
       {"invalid_header", ""},                                 // invalid header
       {very_large_baggage_header, ""}};  // baggage header larger than allowed size.
 
-  for (auto baggage : baggages)
+  for (const auto &baggage : baggages)
   {
     BaggageCarrierTest carrier1;
     carrier1.headers_[baggage::kBaggageHeader.data()] = baggage.first;

diff --git a/api/test/common/kv_properties_test.cc b/api/test/common/kv_properties_test.cc
@@ -31,7 +31,7 @@ TEST(EntryTest, KeyValueConstruction)
 TEST(EntryTest, Copy)
 {
   KeyValueProperties::Entry e("test_key", "test_value");
-  KeyValueProperties::Entry copy(e);
+  const KeyValueProperties::Entry &copy(e);
   EXPECT_EQ(copy.GetKey(), e.GetKey());
   EXPECT_EQ(copy.GetValue(), e.GetValue());
 }

diff --git a/api/test/context/context_test.cc b/api/test/context/context_test.cc
@@ -105,8 +105,8 @@ TEST(ContextTest, ContextCopyOperator)
       {"foo_key", static_cast<int64_t>(456)},
       {"other_key", static_cast<int64_t>(789)}};
 
-  context::Context test_context   = context::Context(test_map);
-  context::Context copied_context = test_context;
+  context::Context test_context          = context::Context(test_map);
+  const context::Context &copied_context = test_context;
 
   EXPECT_EQ(nostd::get<int64_t>(copied_context.GetValue("test_key")), 123);
   EXPECT_EQ(nostd::get<int64_t>(copied_context.GetValue("foo_key")), 456);
@@ -135,7 +135,7 @@ TEST(ContextTest, ContextCopyCompare)
 {
   std::map<std::string, context::ContextValue> map_test = {{"test_key", static_cast<int64_t>(123)}};
   context::Context context_test                         = context::Context(map_test);
-  context::Context copied_test                          = context_test;
+  const context::Context &copied_test                   = context_test;
   EXPECT_TRUE(context_test == copied_test);
 }
 

diff --git a/api/test/context/runtime_context_test.cc b/api/test/context/runtime_context_test.cc
@@ -113,6 +113,7 @@ TEST(RuntimeContextTest, DetachOutOfOrder)
   indices.push_back(3);
 
   std::vector<context::Context> contexts;
+  contexts.reserve(indices.size());
   for (auto i : indices)
   {
     contexts.push_back(context::Context("index", static_cast<int64_t>(i)));
@@ -122,6 +123,7 @@ TEST(RuntimeContextTest, DetachOutOfOrder)
   {
     std::vector<nostd::unique_ptr<context::Token>> tokens;
 
+    tokens.reserve(contexts.size());
     for (auto &c : contexts)
     {
       tokens.push_back(context::RuntimeContext::Attach(c));

diff --git a/api/test/logs/logger_benchmark.cc b/api/test/logs/logger_benchmark.cc
@@ -66,7 +66,7 @@ class Barrier
 static void ThreadRoutine(Barrier &barrier,
                           benchmark::State &state,
                           int thread_id,
-                          std::function<void()> func)
+                          const std::function<void()> &func)
 {
   barrier.Wait();
 
@@ -87,14 +87,15 @@ static void ThreadRoutine(Barrier &barrier,
   barrier.Wait();
 }
 
-void MultiThreadRunner(benchmark::State &state, std::function<void()> func)
+void MultiThreadRunner(benchmark::State &state, const std::function<void()> &func)
 {
   int num_threads = std::thread::hardware_concurrency();
 
   Barrier barrier(num_threads);
 
   std::vector<std::thread> threads;
 
+  threads.reserve(num_threads);
   for (int i = 0; i < num_threads; i++)
   {
     threads.emplace_back(ThreadRoutine, std::ref(barrier), std::ref(state), i, func);

diff --git a/api/test/trace/trace_state_test.cc b/api/test/trace/trace_state_test.cc
@@ -20,7 +20,7 @@ const char *kLongString =
 
 // -------------------------- TraceState class tests ---------------------------
 
-std::string create_ts_return_header(std::string header)
+std::string create_ts_return_header(const std::string &header)
 {
   auto ts = TraceState::FromHeader(header);
   return ts->ToHeader();

diff --git a/examples/http/server.h b/examples/http/server.h
@@ -19,13 +19,13 @@ class HttpServer : public HTTP_SERVER_NS::HttpRequestCallback
   std::atomic<bool> is_running_{false};
 
 public:
-  HttpServer(std::string server_name = "test_server", uint16_t port = 8800) : port_(port)
+  HttpServer(const std::string &server_name = "test_server", uint16_t port = 8800) : port_(port)
   {
     server_.setServerName(server_name);
     server_.setKeepalive(false);
   }
 
-  void AddHandler(std::string path, HTTP_SERVER_NS::HttpRequestCallback *request_handler)
+  void AddHandler(const std::string &path, HTTP_SERVER_NS::HttpRequestCallback *request_handler)
   {
     server_.addHandler(path, *request_handler);
   }

diff --git a/examples/http/tracer_common.h b/examples/http/tracer_common.h
@@ -89,7 +89,8 @@ void CleanupTracer()
   opentelemetry::trace::Provider::SetTracerProvider(none);
 }
 
-opentelemetry::nostd::shared_ptr<opentelemetry::trace::Tracer> get_tracer(std::string tracer_name)
+opentelemetry::nostd::shared_ptr<opentelemetry::trace::Tracer> get_tracer(
+    const std::string &tracer_name)
 {
   auto provider = opentelemetry::trace::Provider::GetTracerProvider();
   return provider->GetTracer(tracer_name);

diff --git a/examples/logs_simple/main.cc b/examples/logs_simple/main.cc
@@ -53,7 +53,7 @@ void InitTracer()
 #endif /* OPENTELEMETRY_DEPRECATED_SDK_FACTORY */
 
   // Set the global trace provider
-  std::shared_ptr<trace_api::TracerProvider> api_provider = provider;
+  const std::shared_ptr<trace_api::TracerProvider> &api_provider = provider;
   trace_api::Provider::SetTracerProvider(api_provider);
 }
 
@@ -79,7 +79,7 @@ void InitLogger()
 #endif /* OPENTELEMETRY_DEPRECATED_SDK_FACTORY */
 
   // Set the global logger provider
-  std::shared_ptr<logs_api::LoggerProvider> api_provider = provider;
+  const std::shared_ptr<logs_api::LoggerProvider> &api_provider = provider;
   logs_api::Provider::SetLoggerProvider(api_provider);
 }
 

diff --git a/examples/multi_processor/main.cc b/examples/multi_processor/main.cc
@@ -70,29 +70,29 @@ void dumpSpans(std::vector<std::unique_ptr<trace_sdk::SpanData>> &spans)
   char span_buf[trace_api::SpanId::kSize * 2];
   char trace_buf[trace_api::TraceId::kSize * 2];
   char parent_span_buf[trace_api::SpanId::kSize * 2];
-  std::cout << "\nSpans from memory :" << std::endl;
+  std::cout << "\nSpans from memory :" << '\n';
 
   for (auto &span : spans)
   {
-    std::cout << "\n\tSpan: " << std::endl;
-    std::cout << "\t\tName: " << span->GetName() << std::endl;
+    std::cout << "\n\tSpan: " << '\n';
+    std::cout << "\t\tName: " << span->GetName() << '\n';
     span->GetSpanId().ToLowerBase16(span_buf);
     span->GetTraceId().ToLowerBase16(trace_buf);
     span->GetParentSpanId().ToLowerBase16(parent_span_buf);
-    std::cout << "\t\tTraceId: " << std::string(trace_buf, sizeof(trace_buf)) << std::endl;
-    std::cout << "\t\tSpanId: " << std::string(span_buf, sizeof(span_buf)) << std::endl;
+    std::cout << "\t\tTraceId: " << std::string(trace_buf, sizeof(trace_buf)) << '\n';
+    std::cout << "\t\tSpanId: " << std::string(span_buf, sizeof(span_buf)) << '\n';
     std::cout << "\t\tParentSpanId: " << std::string(parent_span_buf, sizeof(parent_span_buf))
-              << std::endl;
+              << '\n';
 
-    std::cout << "\t\tDescription: " << span->GetDescription() << std::endl;
+    std::cout << "\t\tDescription: " << span->GetDescription() << '\n';
     std::cout << "\t\tSpan kind:"
               << static_cast<typename std::underlying_type<trace_api::SpanKind>::type>(
                      span->GetSpanKind())
-              << std::endl;
+              << '\n';
     std::cout << "\t\tSpan Status: "
               << static_cast<typename std::underlying_type<trace_api::StatusCode>::type>(
                      span->GetStatus())
-              << std::endl;
+              << '\n';
   }
 }
 }  // namespace

diff --git a/examples/multithreaded/main.cc b/examples/multithreaded/main.cc
@@ -58,6 +58,7 @@ void run_threads()
   auto thread_span = get_tracer()->StartSpan(__func__);
 
   std::vector<std::thread> threads;
+  threads.reserve(5);
   for (int thread_num = 0; thread_num < 5; ++thread_num)
   {
     // This shows how one can effectively use Scope objects to correctly

diff --git a/examples/otlp/http_log_main.cc b/examples/otlp/http_log_main.cc
@@ -61,7 +61,7 @@ void InitTracer()
       trace_opts.url = opentelemetry::exporter::otlp::GetOtlpDefaultHttpTracesEndpoint();
     }
   }
-  std::cout << "Using " << trace_opts.url << " to export trace spans." << std::endl;
+  std::cout << "Using " << trace_opts.url << " to export trace spans." << '\n';
 
   // Create OTLP exporter instance
   auto exporter   = otlp::OtlpHttpExporterFactory::Create(trace_opts);
@@ -100,7 +100,7 @@ std::shared_ptr<opentelemetry::sdk::logs::LoggerProvider> logger_provider;
 
 void InitLogger()
 {
-  std::cout << "Using " << logger_opts.url << " to export log records." << std::endl;
+  std::cout << "Using " << logger_opts.url << " to export log records." << '\n';
   logger_opts.console_debug = true;
   // Create OTLP exporter instance
   auto exporter   = otlp::OtlpHttpLogRecordExporterFactory::Create(logger_opts);