Support for publishing resource attirbutes in fluent logger. #503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I don’t think that’s the case. The change is covered by my CLA, as I am raising the PR. Just for a background - This exporter is maintained by @ThomsonTan and me, and it’s used internally within Microsoft. @bnavarma is one of the users of this within MS :) |
Ok then. |
ThomsonTan
reviewed
Dec 11, 2024
| @@ -99,6 +100,93 @@ void inline PopulateAttribute( | |||
| } | |||
| } | |||
|
|
|||
| void inline PopulateOwnedAttribute( | |||
There was a problem hiding this comment.
nit: wrap this function PopulateOwnedAttribute in the new experimental macro, or we'll get an unused function for build without enabling the experimental flag?
ThomsonTan
approved these changes
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR incorporate changes from #500, as @bnavarma is experiencing issues with CLA signing. The changes are relevant and are gated behind a feature flag."