-
Notifications
You must be signed in to change notification settings - Fork 144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/enable resource attributes #365
base: main
Are you sure you want to change the base?
Feature/enable resource attributes #365
Conversation
… on the traces in Apache and Nginx
5d1842c
to
0071c1d
Compare
@@ -1493,6 +1508,7 @@ | |||
conf->nginxModuleEnabled, | |||
(conf->nginxModuleOtelExporterEndpoint).data, | |||
(conf->nginxModuleOtelExporterOtlpHeaders).data, | |||
(conf->nginxModuleOtelResourceAttributes).data, |
Check failure
Code scanning / CodeQL
Wrong type of arguments to formatting function High
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assume a few lines above the format string should be changed from
Lines 1487 to 1488 in 0071c1d
"(OtelExporterOtlpHeader=\"%s\")" | |
"(OtelSslEnabled=\"%ld\")" |
"(OtelExporterOtlpHeader=\"%s\")"
"(OtelResourceAttributes=\"%s\")"
"(OtelSslEnabled=\"%ld\")"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@christophe-kamphaus-jemmic and can you merge this once I make the changes? This has been stale 6 months and I don't want to keep doing efforts while no one replies...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not a maintainer. I just saw this when I looked into #364.
You might want to join the Opentelemetry Slack channel #otel-cpp and/or the zoom meeting of the C/C++ SIG (every Wed 18:00 CEST) https://github.com/open-telemetry/community?tab=readme-ov-file#calendar and ask there.
@DebajitDas @kpratyus Can you please help here. |
Hey there, any blockers on this getting reviewed and merged in? I'm in a similar situation to what @royteeuwen encountered and would love to get this out in a version. |
No description provided.