Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop anchors.yaml example #130

Merged
merged 2 commits into from
Oct 9, 2024
Merged

Drop anchors.yaml example #130

merged 2 commits into from
Oct 9, 2024

Conversation

jack-berg
Copy link
Member

Resolves #19.

@jack-berg jack-berg requested a review from a team as a code owner October 8, 2024 16:46
marcalff
marcalff requested changes Oct 8, 2024
View reviewed changes
Copy link
Member

@marcalff marcalff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

[malff@malff-desktop opentelemetry-configuration]$ grep -R -l "<<:" *
examples/anchors.yaml
out/anchors.yaml

For completeness,
please remove the validation test out/anchors.yaml,
and adjust file validator/shelltests/examples.test accordingly.

@jack-berg
Copy link
Member Author

please remove the validation test out/anchors.yaml,

This file isn't checked into version control

and adjust file validator/shelltests/examples.test accordingly.

👍

marcalff
marcalff approved these changes Oct 8, 2024
View reviewed changes
Copy link
Member

@marcalff marcalff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@marcalff
Copy link
Member

marcalff commented Oct 8, 2024

please remove the validation test out/anchors.yaml,

This file isn't checked into version control

Indeed, I got fooled by my local repo after a build, sorry about that.

@jack-berg jack-berg merged commit 844869c into open-telemetry:main Oct 9, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcalff marcalff marcalff approved these changes

@trask trask trask approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Confirm yaml anchors can be extended
3 participants
@jack-berg @marcalff @trask