[receiver/otlp] Refactor http error handling #9893
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR slightly refactors the otlp receiver's HTTP error handling. The result is a few less calls to
status.FromError
, increased accuracy in the grpc code included in the body of the response, and centralizing http<->grpc mapping in theinternal/errors
package.This PR intentionally changes how we map from HTTP status code to grpc
Status.code
. I don't consider this to be a breaking change, or even worthy of a changelog, since the specification states that"The clients are not expected to alter their behavior based on Status.code field but MAY record it for troubleshooting purposes."
Honestly, I'd be ok if we chose to stop including theStatus.code
entirely as it leads to more confusion in the code and payload in my opinion.Link to tracking Issue:
Closes #9864
Testing:
Added new tests