Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[exporterhelper] Add default batching for OTLP data type #9738

Merged
merged 1 commit into from
Mar 27, 2024

Conversation

dmitryax
Copy link
Member

@dmitryax dmitryax commented Mar 11, 2024

Introduce default batching functionality based on the internal data type (pdata). This makes the exporter batching capability available to the regular exporter helpers without using custom requests.

Updates #8122

Copy link

codecov bot commented Mar 11, 2024

Codecov Report

Attention: Patch coverage is 99.26650% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 91.32%. Comparing base (6af868f) to head (b69a84c).
Report is 1 commits behind head on main.

Files Patch % Lines
exporter/exporterhelper/traces_batch.go 96.93% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9738      +/-   ##
==========================================
+ Coverage   91.14%   91.32%   +0.18%     
==========================================
  Files         353      356       +3     
  Lines       18772    19163     +391     
==========================================
+ Hits        17109    17500     +391     
  Misses       1335     1335              
  Partials      328      328              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dmitryax dmitryax added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Mar 12, 2024
@dmitryax dmitryax marked this pull request as ready for review March 12, 2024 00:15
@dmitryax dmitryax requested review from a team and jpkrohling March 12, 2024 00:15
@dmitryax dmitryax force-pushed the otlp-batching branch 4 times, most recently from 20e1707 to 3fd7a3d Compare March 12, 2024 03:20
Copy link
Contributor

@splunkericl splunkericl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the merge and mergeSplit function. This makes using exporter batching framework much easier.

@dmitryax dmitryax force-pushed the otlp-batching branch 2 times, most recently from 064c93c to c113899 Compare March 12, 2024 23:25
Copy link
Member

@mx-psi mx-psi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just two minor nits to clarify the code

exporter/exporterhelper/metrics_batch.go Outdated Show resolved Hide resolved
exporter/exporterhelper/metrics_batch.go Outdated Show resolved Hide resolved
Make the exporter batching capability to be available for the regular exporter helper without using custom requests.
@dmitryax dmitryax merged commit 4b5d68e into open-telemetry:main Mar 27, 2024
48 checks passed
@github-actions github-actions bot added this to the next release milestone Mar 27, 2024
@dmitryax dmitryax deleted the otlp-batching branch April 15, 2024 20:40
dmitryax pushed a commit to open-telemetry/opentelemetry-collector-contrib that referenced this pull request May 4, 2024
**Description:** 
Add a new feature in splunk hec exporter
- utilitize batching framework
open-telemetry/opentelemetry-collector#9738 in
splunk hec exporter
- adds batcher config in splunk hec exporter config and append it as
exporter option if enabled

**Link to tracking Issue:**
Resolves
#32545

**Testing:**
Added unit test for the config

**Documentation:**
Updated the README file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants