-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[configgrpc] Remove deprecated functions/structs #9616
Merged
dmitryax
merged 5 commits into
open-telemetry:main
from
TylerHelmuth:configgrpc-remove-deprecated-items
Feb 27, 2024
Merged
[configgrpc] Remove deprecated functions/structs #9616
dmitryax
merged 5 commits into
open-telemetry:main
from
TylerHelmuth:configgrpc-remove-deprecated-items
Feb 27, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TylerHelmuth
commented
Feb 20, 2024
TylerHelmuth
changed the title
[confignet] Remove deprecated functions/structs
[configgrpc] Remove deprecated functions/structs
Feb 20, 2024
TylerHelmuth
force-pushed
the
configgrpc-remove-deprecated-items
branch
2 times, most recently
from
February 21, 2024 01:42
1752307
to
d537d0d
Compare
TylerHelmuth
commented
Feb 21, 2024
TylerHelmuth
force-pushed
the
configgrpc-remove-deprecated-items
branch
from
February 21, 2024 01:59
d537d0d
to
a47e5fe
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9616 +/- ##
==========================================
- Coverage 90.89% 90.87% -0.02%
==========================================
Files 347 347
Lines 18325 18323 -2
==========================================
- Hits 16656 16651 -5
- Misses 1344 1346 +2
- Partials 325 326 +1 ☔ View full report in Codecov by Sentry. |
open-telemetry/opentelemetry-collector-contrib#31360 is ready for review |
dmitryax
approved these changes
Feb 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Removes deprecated functions/structs
Link to tracking Issue:
Related to #9428
Related to #9482
Closes #9481