Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] [exporterhelper] Remove duplicated code between exporter helpers #9603

Merged
merged 1 commit into from
Feb 20, 2024

Conversation

dmitryax
Copy link
Member

@dmitryax dmitryax commented Feb 19, 2024

No description provided.

@dmitryax dmitryax requested review from a team and jpkrohling February 19, 2024 19:44
@dmitryax dmitryax force-pushed the simplify-exporter-helper branch from fbbd2d5 to a0095a2 Compare February 19, 2024 19:48
Copy link

codecov bot commented Feb 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0ab8f44) 90.62% compared to head (971706f) 90.70%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9603      +/-   ##
==========================================
+ Coverage   90.62%   90.70%   +0.08%     
==========================================
  Files         347      347              
  Lines       18232    18199      -33     
==========================================
- Hits        16522    16507      -15     
+ Misses       1381     1369      -12     
+ Partials      329      323       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dmitryax dmitryax force-pushed the simplify-exporter-helper branch 2 times, most recently from 7f3a16d to 251aaf0 Compare February 20, 2024 00:41
@dmitryax dmitryax force-pushed the simplify-exporter-helper branch from 251aaf0 to 971706f Compare February 20, 2024 02:47
@dmitryax dmitryax added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Feb 20, 2024
@dmitryax dmitryax changed the title [exporterhelper] Adds functions to convert pdata types into Request [chore] [exporterhelper] Remove duplicated code between exporter helpers Feb 20, 2024
@dmitryax dmitryax merged commit e7770fc into open-telemetry:main Feb 20, 2024
51 of 63 checks passed
@github-actions github-actions bot added this to the next release milestone Feb 20, 2024
@dmitryax dmitryax deleted the simplify-exporter-helper branch February 21, 2024 05:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants