[configtls] Rename config structs for consistency #9495
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I just ran this: rg "TLSClientSetting" -l --type go | xargs -I{} sh -c "gsed -i 's/TLSClientSetting/ClientConfig/g' {}"
rg "TLSServerSetting" -l --type go | xargs -I{} sh -c "gsed -i 's/TLSServerSetting/ServerConfig/g' {}"
rg "TLSSetting" -l --type go | xargs -I{} sh -c "gsed -i 's/TLSSetting/Config/g' {}"Will take care of any tests that fail (not expecting anything to fail though). |
arjunmahishi
force-pushed
the
rename-config-structs
branch
from
b08a147 to
49a29fc
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9495 +/- ##
=======================================
Coverage 90.89% 90.89%
=======================================
Files 347 347
Lines 18324 18324
=======================================
Hits 16655 16655
Misses 1344 1344
Partials 325 325 ☔ View full report in Codecov by Sentry. |
evan-bradley
reviewed
Feb 7, 2024
mx-psi
added
needed-for-1.0
release:required-for-ga
arjunmahishi
force-pushed
the
rename-config-structs
branch
2 times, most recently
from
88dfcf1 to
6df20bc
Compare
bogdandrutu
approved these changes
Feb 9, 2024
evan-bradley
approved these changes
Feb 13, 2024
jpkrohling
approved these changes
Feb 14, 2024
TylerHelmuth
approved these changes
Feb 14, 2024
jpkrohling
changed the title
|
Can this be merged? or am I missing a step? |
andrzej-stencel
approved these changes
Feb 16, 2024
TylerHelmuth
added
the
ready-to-merge
|
@arjunmahishi please take a look at the conflict. |
This commit renames the following structs: * TLSClientSetting to ClientConfig * TLSServerSetting to ServerConfig * TLSSetting to Config This is based on the naming convention followed in other config packages. Fixes open-telemetry#9474
arjunmahishi
force-pushed
the
rename-config-structs
branch
from
5be2d60 to
082dfaf
Compare
Done |
dmitryax
reviewed
Feb 28, 2024
| # (Optional) One or more lines of additional information to render under the primary note. | ||
| # These lines will be padded with 2 spaces and then inserted directly into the document. | ||
| # Use pipe (|) for multiline entries. | ||
| subtext: |
There was a problem hiding this comment.
Can you please list all the renames here, e.g.:
Suggested change
| subtext: | |
| subtext: | | |
| - TLSClientSetting -> ClientConfig |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Simply renames a few structs in the
configtlspackage for consistence.TLSClientSettingtoClientConfigTLSServerSettingtoServerConfigTLSSettingtoConfigLink to tracking Issue:
Fixes #9474