[service] Replace telemetryInitializer by MeterProvider wrapper #9454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #9454 +/- ##
==========================================
- Coverage 90.56% 90.55% -0.01%
==========================================
Files 347 347
Lines 18234 18247 +13
==========================================
+ Hits 16513 16524 +11
- Misses 1389 1392 +3
+ Partials 332 331 -1 ☔ View full report in Codecov by Sentry. |
|
@codeboten could you take a look? |
codeboten
approved these changes
Feb 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Refactor meter provider initialization; removes
telemetryInitializerand replaces it by a MeterProvider wrapper that owns the lifetime of the OpenCensus registry and the servers associated with the MeterProvider.Link to tracking Issue: Relates to #4970 (first refactor before trying out the factory pattern in an internal package)