Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[service/telemetry] Deprecate telemetry.Settings in favor of telemetry.CreateSettings #9406

Closed
wants to merge 1 commit into from

Conversation

mx-psi
Copy link
Member

@mx-psi mx-psi commented Jan 26, 2024

Description: Deprecate telemetry.Settings in favor of telemetry.CreateSettings. This is for consistency with how we name similar structs in exporters, receivers, processors, connectors and extensions.

@mx-psi mx-psi force-pushed the mx-psi/createsettings branch from 6005f4a to e1555dd Compare January 26, 2024 12:21
@mx-psi mx-psi marked this pull request as ready for review January 26, 2024 12:28
@mx-psi mx-psi requested review from a team and Aneurysm9 January 26, 2024 12:28
Copy link

codecov bot commented Jan 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9082cb1) 90.23% compared to head (e1555dd) 90.22%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9406      +/-   ##
==========================================
- Coverage   90.23%   90.22%   -0.02%     
==========================================
  Files         345      345              
  Lines       18019    18019              
==========================================
- Hits        16260    16257       -3     
- Misses       1431     1433       +2     
- Partials      328      329       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dmitryax
Copy link
Member

The Create prefix for the receivers, processors, and exporters comes from the fact that it's passed to functions like exporter.CreateLogsFunc. @bogdandrutu made this point recently. Given that it's passed to the telemetry constructor, maybe we can also rename this one. However, I think we need to take into account other Settings in the project to decide. It is probably better to start with an issue

@mx-psi
Copy link
Member Author

mx-psi commented Jan 26, 2024

The Create prefix for the receivers, processors, and exporters comes from the fact that it's passed to functions like exporter.CreateLogsFunc. @bogdandrutu made this point recently. Given that it's passed to the telemetry constructor, maybe we can also rename this one. However, I think we need to take into account other Settings in the project to decide. It is probably better to start with an issue

I want to move towards #4970 (comment), which I guess would align this, but I still think this change makes sense in isolation (in that they are settings used to create the telemetry providers)

bogdandrutu
bogdandrutu previously approved these changes Jan 29, 2024
@bogdandrutu bogdandrutu dismissed their stale review January 29, 2024 21:17

Confused about the #4970

@mx-psi
Copy link
Member Author

mx-psi commented Jan 30, 2024

Closing until we discuss #9428. Not sure if I captured the questions we want to decide on correctly, PTAL

@mx-psi mx-psi closed this Jan 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants