Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[config/confighttp] Deprecate CORSSettings, use CORSConfig instead #9392

Merged
merged 2 commits into from
Jan 26, 2024

Conversation

atoulme
Copy link
Contributor

@atoulme atoulme commented Jan 25, 2024

Description:
Deprecate CORSSettings, use CORSConfig instead

Link to tracking Issue:
#6767

Copy link

codecov bot commented Jan 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6b3b181) 90.23% compared to head (36ccec2) 90.19%.
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9392      +/-   ##
==========================================
- Coverage   90.23%   90.19%   -0.04%     
==========================================
  Files         345      345              
  Lines       18017    18019       +2     
==========================================
- Hits        16257    16252       -5     
- Misses       1431     1437       +6     
- Partials      329      330       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@TylerHelmuth TylerHelmuth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming we're still on board with Config over Settings this looks right to me. Thanks for starting these deprecations early!

@atoulme
Copy link
Contributor Author

atoulme commented Jan 25, 2024

I assumed we were still going with those. They'll make checking APIs much easier.

@dmitryax dmitryax merged commit 9082cb1 into open-telemetry:main Jan 26, 2024
32 checks passed
@github-actions github-actions bot added this to the next release milestone Jan 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants