[receiver/otlpreceiver] Enable goleak check #9225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9225 +/- ##
==========================================
- Coverage 90.38% 90.16% -0.22%
==========================================
Files 341 345 +4
Lines 17986 18028 +42
==========================================
- Hits 16256 16255 -1
- Misses 1407 1443 +36
- Partials 323 330 +7 ☔ View full report in Codecov by Sentry. |
bogdandrutu
reviewed
Jan 5, 2024
crobert-1
changed the title
crobert-1
force-pushed
the
goleak_otlpreceiver
branch
from
e91e3a0 to
af1074f
Compare
|
Failing test is frequency of #9230 |
crobert-1
force-pushed
the
goleak_otlpreceiver
branch
from
af1074f to
e826098
Compare
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
bogdandrutu
reviewed
Jan 24, 2024
TylerHelmuth
approved these changes
Jan 24, 2024
bogdandrutu
approved these changes
Feb 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Add
goleakto detect leaks in tests. Leaking goroutines were detected that were caused by a dependency that we can ignore (go.opencensus.io/stats/view.(*worker).start), aShutdowncall was also added that was missing.Link to tracking Issue:
#9165
Testing:
Added check is passing as well as existing tests.