-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[confmap] Return error when decoding negative values into uints #9169
[confmap] Return error when decoding negative values into uints #9169
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9169 +/- ##
=======================================
Coverage 91.77% 91.77%
=======================================
Files 359 359
Lines 16631 16637 +6
=======================================
+ Hits 15263 15269 +6
Misses 1041 1041
Partials 327 327 ☔ View full report in Codecov by Sentry. |
2ea573e
to
d8707cc
Compare
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
d8707cc
to
a531fc7
Compare
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
661dc8b
to
be15997
Compare
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
I believe this is ready to be merged. @bogdandrutu Do you have any concerns here? |
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
This adds a decode hook for unmarshalling negative integers into uint types. This will now return an error instead of converting negative values into large uint values.
- Add test case for uint64(-1000) conversion - Clean existing test case
33771c1
to
de96bcb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This comes from #9532. Can we add a note to remove the hook once we disable WeaklyTypedInput
?
Done. I've added a TODO referencing the issue. 👍 |
Description:
This adds a decode hook for unmarshalling negative integers into uint types. This will now return an error instead of converting negative values into large uint values.
Link to tracking Issue:
Fixes #9060
Testing:
Added unit tests for confmap functionality, functional tests in memory limiter processor (the original component this issue was filed against)