Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[confignet] Add new functions that take Context #9163

Merged
merged 3 commits into from
Dec 20, 2023

Conversation

TylerHelmuth
Copy link
Member

Description:
Deprecates the Dial and Listen functions in favor of DialContext and ListenContext.

Link to tracking Issue:
Related to #9105

Testing:
Updated unit tests

Documentation:
Added godoc comments

@TylerHelmuth TylerHelmuth requested review from a team and codeboten December 20, 2023 18:45
Copy link

codecov bot commented Dec 20, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (44fbb84) 91.41% compared to head (79685f8) 91.39%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9163      +/-   ##
==========================================
- Coverage   91.41%   91.39%   -0.02%     
==========================================
  Files         320      320              
  Lines       17187    17199      +12     
==========================================
+ Hits        15711    15719       +8     
- Misses       1173     1177       +4     
  Partials      303      303              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

.chloggen/confignet-now-with-ctx.yaml Outdated Show resolved Hide resolved
@bogdandrutu bogdandrutu merged commit 49c5b6f into open-telemetry:main Dec 20, 2023
32 checks passed
@github-actions github-actions bot added this to the next release milestone Dec 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants