[service] use WithNamespace instead of WrapRegistererWithPrefix
#8988
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using this functionality in the otel prom exporter fixes a bug where the target_info was prefixed as otelcol_target_info previously. Signed-off-by: Alex Boten <[email protected]>
added 2 commits
November 23, 2023 10:40
Signed-off-by: Alex Boten <[email protected]>
Signed-off-by: Alex Boten <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8988 +/- ##
==========================================
- Coverage 91.55% 91.54% -0.02%
==========================================
Files 316 315 -1
Lines 17111 17117 +6
==========================================
+ Hits 15666 15669 +3
- Misses 1150 1152 +2
- Partials 295 296 +1 ☔ View full report in Codecov by Sentry. |
bogdandrutu
reviewed
Nov 23, 2023
codeboten
commented
Nov 23, 2023
1 task
mx-psi
approved these changes
Nov 24, 2023
pantuza
pushed a commit
to pantuza/opentelemetry-collector
that referenced
this pull request
Dec 8, 2023
…pen-telemetry#8988) Using this functionality in the otel prom exporter fixes a bug where the target_info was prefixed as otelcol_target_info previously. --------- Signed-off-by: Alex Boten <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using this functionality in the otel prom exporter fixes a bug where the target_info was prefixed as otelcol_target_info previously.