Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] rename internal Queue func to Offer; return error #8884

Merged
merged 1 commit into from
Nov 14, 2023

Conversation

bogdandrutu
Copy link
Member

No description provided.

@bogdandrutu bogdandrutu requested review from a team and mx-psi November 14, 2023 04:30
Copy link

codecov bot commented Nov 14, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (d0f9a78) 90.86% compared to head (487da8b) 90.86%.

❗ Current head 487da8b differs from pull request most recent head 31f8454. Consider uploading reports for the commit 31f8454 to get more accurate results

Files Patch % Lines
exporter/exporterhelper/logs.go 50.00% 0 Missing and 1 partial ⚠️
exporter/exporterhelper/metrics.go 50.00% 0 Missing and 1 partial ⚠️
exporter/exporterhelper/traces.go 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8884      +/-   ##
==========================================
- Coverage   90.86%   90.86%   -0.01%     
==========================================
  Files         317      317              
  Lines       17213    17212       -1     
==========================================
- Hits        15641    15640       -1     
  Misses       1281     1281              
  Partials      291      291              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@dmitryax dmitryax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@bogdandrutu bogdandrutu merged commit e873023 into open-telemetry:main Nov 14, 2023
28 of 29 checks passed
@bogdandrutu bogdandrutu deleted the offer branch November 14, 2023 05:00
@github-actions github-actions bot added this to the next release milestone Nov 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants