Fix connector logger zap kind key #8878
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bogdandrutu
force-pushed
the
fixconnectorlogger
branch
from
998c3e9 to
3073689
Compare
bogdandrutu
commented
Nov 14, 2023
| @@ -25,34 +22,34 @@ const ( | |||
|
|
|||
| func ReceiverLogger(logger *zap.Logger, id component.ID, dt component.DataType) *zap.Logger { | |||
| return logger.With( | |||
| zap.String(zapKindKey, zapKindReceiver), | |||
| zap.String(zapKindKey, strings.ToLower(component.KindReceiver.String())), | |||
There was a problem hiding this comment.
Using ToLower just to make sure we are not changing the previous strings. The String() method returns upper case to be consistent with other funcs like StabilityLevel.
bogdandrutu
force-pushed
the
fixconnectorlogger
branch
from
3073689 to
2596796
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8878 +/- ##
=======================================
Coverage 90.86% 90.87%
=======================================
Files 317 317
Lines 17212 17225 +13
=======================================
+ Hits 15640 15653 +13
Misses 1281 1281
Partials 291 291 ☔ View full report in Codecov by Sentry. |
dmitryax
approved these changes
Nov 14, 2023
Signed-off-by: Bogdan Drutu <[email protected]>
bogdandrutu
force-pushed
the
fixconnectorlogger
branch
from
2596796 to
aec4873
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.