Simplify logic in boundedMemoryQueue, use channels len/cap #8829
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
bogdandrutu
force-pushed
the
simplifyqueue
branch
2 times, most recently
from
6e2fff4 to
9e68417
Compare
bogdandrutu
commented
Nov 8, 2023
| @@ -247,11 +247,24 @@ func (s *consumerState) assertConsumed(expected map[string]bool) { | |||
| assert.Equal(s.t, expected, s.snapshot()) | |||
| } | |||
|
|
|||
| func TestZeroSize(t *testing.T) { | |||
| func TestZeroSizeWithConsumers(t *testing.T) { | |||
There was a problem hiding this comment.
There is a small behavior change here if capacity/size is 0 and numConsumers >0. But this is not a valid case in QueueConfig, see Validate so we should not worry.
yurishkuro
approved these changes
Nov 8, 2023
dmitryax
approved these changes
Nov 9, 2023
|
Submitted #8832 to make the test pass |
atoulme
reviewed
Nov 9, 2023
|
@bogdandrutu please rebase |
Signed-off-by: Bogdan Drutu <[email protected]>
bogdandrutu
force-pushed
the
simplifyqueue
branch
from
9e68417 to
0347416
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
... and 1 file with indirect coverage changes 📢 Thoughts on this report? Let us know! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.