[cmd/builder] Fix otelcol_version being ignored #8713
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Adds
go.opentelemetry.io/collector/otelcol
togo.mod
template for the builder. This fixes #8692.Since #8443, the
otelcol
folder is its own component. Before this change,otelcol_version
was enforced by thecollector
module dependency:opentelemetry-collector/cmd/builder/internal/builder/templates/go.mod.tmpl
Line 23 in 287b98f
After this change, the
go mod tidy
step here:opentelemetry-collector/cmd/builder/internal/builder/main.go
Line 115 in 287b98f
will add the latest available version for the
otelcol
module since none of the components actually depend on it. For example, with thev0.86.0
builder config the output is as follows:Explicitly adding
otelcol
makes it so theotelcol_version
is correctly honored.Link to tracking Issue: Fixes #8692