-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[receiver/otlp, internal, featuregate] Add featuregate to switch to localhost defaults for server-like components #8622
[receiver/otlp, internal, featuregate] Add featuregate to switch to localhost defaults for server-like components #8622
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #8622 +/- ##
==========================================
- Coverage 90.24% 90.14% -0.11%
==========================================
Files 344 345 +1
Lines 17996 18025 +29
==========================================
+ Hits 16240 16248 +8
- Misses 1428 1446 +18
- Partials 328 331 +3 ☔ View full report in Codecov by Sentry. |
9b0dcd9
to
7343a0b
Compare
…faults for server-like components
7343a0b
to
8f14eb0
Compare
To see the usage of this API on contrib take a look at open-telemetry/opentelemetry-collector-contrib/pull/27439 |
Adding some people that commented on the original issue as reviewers :) PTAL! |
@jpkrohling after the last commit we now warn per component and only if the endpoint is not set. The approach is similar to what I did for the opentelemetry-collector/exporter/loggingexporter/config.go Lines 41 to 42 in 5c225d9
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just have concern with sharing the gate (code) and then removing the code.
@bogdandrutu see #8622 (comment) for an alternative way of doing this |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
@bogdandrutu (and others) will merge this by Wednesday EU morning (after this week's core release) unless somebody objects before then :) |
**Description:** Follow up to open-telemetry/opentelemetry-collector/pull/8622 **Link to tracking Issue:** First step of #30702
**Description:** Follow up to open-telemetry/opentelemetry-collector/pull/8622 **Link to tracking Issue:** First step of open-telemetry#30702
Description:
component.UseLocalHostAsDefaultHost
in theinternal/localhostgate
package.featuregate.ErrIsAlreadyRegistered
error, returned byRegister
when a gate is already registered.This PR does not remove the current warning in any way, we can remove this separately.
Link to tracking Issue: Updates #8510
Testing: Adds unit tests
Documentation: Document on OTLP receiver template and add related logging.