-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for :authority pseudo-header for grpc client #8228
Conversation
|
4355c53
to
77e8f9c
Compare
77e8f9c
to
fc879dc
Compare
This adds support for configuring authority dial option in grpc client
fc879dc
to
df80854
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution @enuret. The change looks ok, i'm not familiar w/ the :authority
header can you tell me a bit more about the use-case for setting it?
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #8228 +/- ##
==========================================
- Coverage 90.30% 90.27% -0.04%
==========================================
Files 301 301
Lines 15581 15584 +3
==========================================
- Hits 14071 14068 -3
- Misses 1222 1227 +5
- Partials 288 289 +1
☔ View full report in Codecov by Sentry. |
Hey @codeboten! Thanks for doing the review! This header is a destination host-name by default. My particular case is configuring envoy to balance traffic between two opentelemetry collectors or between opentelemetry collector and data backend and using envoy virtual hosts to match backends. So, envoy uses ":authority" header for http/2 requests to match them to virtual hosts: https://www.envoyproxy.io/docs/envoy/latest/configuration/http/http_conn_man/route_matching In my case the example call will look like: By default, :authority header will be equal "envoyhost" because it is the endpoint address but if "backend" will be specified in :authority header it will be possible to match it based on Virtual host domain name in envoy. For example, it will let routing based on domain name with configuration like it :
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the info 👍🏻
This adds support for configuring
authority
dial option for grpc exporter